[Woo POS][Local Catalog] Update properties for POS entities #16060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Fix description use when making persistedproduct
1 task
jaclync
approved these changes
Sep 1, 2025
Contributor
jaclync
left a comment
jaclync
left a comment
There was a problem hiding this comment.
Thanks for cleaning up the POS properties, POS works as before 🚢
| public let productID: Int64 | ||
| public let name: String | ||
| public let productTypeKey: String | ||
| public let fullDescription: String? |
Contributor
There was a problem hiding this comment.
interesting that shortDescription requires periphery ignore but this one doesn't 🤔
…d' into woomob-1210-relationship-based-mapping-and-saving-for-POS-entities
…OS-entities' into woomob-1210-tests-for-saving-pos-models
Collaborator
Generated by 🚫 Danger |
joshheald
deleted the
woomob-1210-remove-unused-properties-from-pos-entities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: WOOMOB-1210
Description
This PR removes the sale price properties which aren't used in POS, and adds description properties in preparation for use in search.
Stock management fields are left in – there's code in POS which uses them, though it's currently feature flagged.
Steps to reproduce
None of the fields make any difference to the user experience – check the app runs, that you can still load POS and browse products/variations, and that unit tests pass.
RELEASE-NOTES.txtif necessary.